Enable comparator on nRF54L20 #2781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Apr 17, 2025
Include Enable comparator on nRF54L20 zephyrproject-rtos/zephyr#88745 nrfconnect/sdk-zephyr#2781 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
force-pushed
the
NRFX-7312_Enable-comparator-on-54L20
branch
from
775da1e to
b5faf5c
Compare
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Apr 17, 2025
Include Enable comparator on nRF54L20 zephyrproject-rtos/zephyr#88745 nrfconnect/sdk-zephyr#2781 Signed-off-by: Sebastian Głąb <[email protected]>
…F54L20 Add mapping from analogue input channel to GPIO number on nRF54L20. Make changes to both comparator and low power comparator. Upstream PR #: 88745 Signed-off-by: Sebastian Głąb <[email protected]>
Test uses AIN4 and AIN5. Unfortunately, these inputs on nRF54L20 are used by serial port console. When test is compiled for nRF54L20, use other anlogue inputs. Upstream PR #: 88745 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
force-pushed
the
NRFX-7312_Enable-comparator-on-54L20
branch
from
b5faf5c to
954eaf2
Compare
|
nordic-piks
reviewed
Apr 22, 2025
| @@ -15,20 +15,30 @@ static const struct gpio_dt_spec test_pin_2 = GPIO_DT_SPEC_GET(DT_PATH(zephyr_us | |||
|
|
|||
|
|
|||
| struct comp_nrf_comp_se_config comp_se_config = { | |||
| #if defined(CONFIG_BOARD_NRF54LM20APDK) | |||
There was a problem hiding this comment.
There is no such board at upstream, maybe feature flag?
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Apr 22, 2025
Include Enable comparator on nRF54L20 zephyrproject-rtos/zephyr#88745 nrfconnect/sdk-zephyr#2781 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Apr 23, 2025
Include Enable comparator on nRF54L20 zephyrproject-rtos/zephyr#88745 nrfconnect/sdk-zephyr#2781 Signed-off-by: Sebastian Głąb <[email protected]>
|
Implemented in a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend comparator drivers with analogue input to GPIO pin mapping.
In comparator test, use other analogue inputs.
manifest-pr-skip